This repository has been archived by the owner on Mar 23, 2019. It is now read-only.
Fix main entry in package.json
#8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't publish this change, I no longer have publish access to that module. |
|
@dominictarr thanks, I did not notice that before. I also saw that you archived |
|
github.com/MetaMask said they would maintain it (since they use it and are high value target) they are added as npm owner, but need to fork JSONStream on github. probably you need to hassle them on twitter. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
assert.jsfile. The module resolve algorithm is very forgiving at the moment and also tries to resolve theindex.jsfile in a directory even though themainentry is invalid. That's why this currently works.This could likely change for Node.js v12 (nodejs/node#26823) and it would be great to fix this.